feat: decouple datasource connectivity from privilege checks - #658
Open
LordofAvernus wants to merge 2 commits into
Open
feat: decouple datasource connectivity from privilege checks#658LordofAvernus wants to merge 2 commits into
LordofAvernus wants to merge 2 commits into
Conversation
Split IsConnectable and privilege reply semantics; add unit tests for plugin exemption, allowlist unsupported path, and privilege reply field mapping.
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/dms-ee/issues/950
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docMade with Cursor
Description
新增数据库服务权限回复及数据结构
修改连通性检测中插件错误处理逻辑
增加自动权限检测与允许列表处理
添加单元测试覆盖多种数据库场景
Diagram Walkthrough
File Walkthrough
4 files
更新权限回复数据结构及映射类型增加插件检测及自动权限检查逻辑更新项目服务权限映射处理逻辑新增获取权限路由映射接口2 files
添加连通性与权限检测单元测试添加权限回复映射功能测试1 files
新增代码审核清单配置文件