Skip to content

Use System.Buffers Nuget package - #478

Merged
adamhathcock merged 2 commits into
adamhathcock:masterfrom
Bond-009:buffers
Sep 17, 2019
Merged

Use System.Buffers Nuget package#478
adamhathcock merged 2 commits into
adamhathcock:masterfrom
Bond-009:buffers

Conversation

@Bond-009

Copy link
Copy Markdown
Contributor

No description provided.

@adamhathcock

Copy link
Copy Markdown
Owner

Please describe why this is necessary for you. I think I did it my way because of platform targeting issues

@Bond-009

Copy link
Copy Markdown
Contributor Author

@adamhathcock what issues? I did this because it's best practice not to include libs in source control, but via a package manager (i.e Nuget)

@adamhathcock

Copy link
Copy Markdown
Owner

That’s great and all but the older platforms didn’t like the multi-targeting. Build isn’t passing anyway.

If I go netstandard only then this will be a thing to do. I didn’t take it lightly then choosing to absorbing code instead of a reference

@Bond-009

Copy link
Copy Markdown
Contributor Author

@adamhathcock Fixed the build

@adamhathcock
adamhathcock merged commit 17d5565 into adamhathcock:master Sep 17, 2019
@Bond-009
Bond-009 deleted the buffers branch September 17, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants