Skip to content

bug(storyboard): media_buy_seller/refine_products/get_products_refine sends buying_mode='refine' with brief #702

Description

@bokelley

Surfaced by #693.

Failure

media_buy_seller/refine_products/get_products_refine [media_buy]:
  INVALID_REQUEST: buying_mode='refine' must not be combined with brief.
  The refine[] array drives iteration on a previous get_products response.

What this says

The storyboard step get_products_refine is constructing a get_products request with both buying_mode='refine' AND a brief field. The seller is correctly rejecting it as INVALID_REQUEST. That means either:

  1. The storyboard step is wrong — refine mode should drop brief and pass only the refine[] array, OR
  2. The spec on buying_mode='refine' shifted and brief is now allowed in this combination, but the seller's validation hasn't caught up.

The seller's rejection text reads like option (1): "must not be combined with brief" is a hard rule.

Run

ci run 25732467897

What to investigate

Check the storyboard scenario file for refine_products and confirm the step's request shape. Cross-reference against the AdCP get_products spec for which fields are valid alongside buying_mode='refine'.

If the storyboard is the wrong side: fix the scenario, regenerate fixtures.
If the seller is the wrong side: relax the validation rule.

Why it blocks #693

Same as #701 — until this storyboard step passes, the storyboard CI gate cannot go green.

Acceptance

  • media_buy_seller/refine_products/get_products_refine passes the storyboard with a correctly-shaped request
  • Root cause documented in the fix PR (storyboard fixture vs seller validation)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions