Skip to content

chore(schemas): bump ADCP_VERSION 3.0.7 → 3.0.12, drop hand-patched compact-form schema cache #771

Description

@bokelley

Background

PR #753 (feat(adagents): publisher_domains compact form, revoked_publisher_domains, streaming fetch caps) hand-patched the cached 3.0 schemas to add the publisher_domains[] compact form on publisher-property-selector and revoked_publisher_domains[] on adagents.json. The commit message explicitly noted:

The cached schemas will be overwritten on the next make regenerate-schemas once upstream 3.0.10+ ships and ADCP_VERSION is bumped — the runtime / test changes are independent of the cached schema text.

Upstream is now at 3.0.12. The SDK is pinned to 3.0.7 (src/adcp/ADCP_VERSION). Time to bump and drop the hand-patch.

Scope

  1. Edit src/adcp/ADCP_VERSION from 3.0.73.0.12.
  2. Run make regenerate-schemas (executes scripts/sync_schemas.py).
  3. Diff the regenerated src/adcp/types/_generated.py and src/adcp/types/generated_poc/**. Expected to converge with the hand-patched compact-form + revocation surfaces; flag any new shape that wasn't anticipated.
  4. Remove the hand-patch comments / TODOs left by feat(adagents): publisher_domains compact form, revoked_publisher_domains, streaming fetch caps (closes #729) #753 in the cached schemas.
  5. Re-run pytest tests/test_adagents.py tests/test_validation*.py to confirm runtime behaviour is unchanged.

Risks

  • 3.0.7 → 3.0.12 is five point releases of drift. Likely other schema additions/changes between (new event types, field reordering, enum extensions). Each needs review on its own merits.
  • CI's check-schema-drift Make target will now fail if upstream 3.0.12 doesn't include the exact compact-form / revocation shape feat(adagents): publisher_domains compact form, revoked_publisher_domains, streaming fetch caps (closes #729) #753 anticipated. In that case, choose between (a) re-patching the cache to match upstream and bumping to 3.0.13+ when it lands, or (b) waiting on a corrective upstream release.

Out of scope

References

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions