Fix invoice modal positioning: center modals on screen - #536
Merged
Conversation
The invoice request modal was appearing at the bottom of the page instead of centered. This happened because the inline styles had flexbox alignment properties but no display:flex, so when JavaScript set display:flex it didn't properly enable the centering. Fixed by: - dashboard-membership.html: Use existing .profile-modal-overlay class instead of inline styles for both invoice and agreement modals - join-cta.js: Call injectJoinCtaStyles() in openInvoiceRequestModal() to ensure the modal overlay CSS is loaded before creating the modal 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display: flex, the centering didn't work properlyChanges
.profile-modal-overlayclass instead of inline styles for both invoice and agreement modalsinjectJoinCtaStyles()inopenInvoiceRequestModal()to ensure the modal overlay CSS is loaded before creating the modalTest plan
🤖 Generated with Claude Code