fix(destination-bigquery): use CREATE TABLE IF NOT EXISTS for non-replace table creation#82102
Conversation
…lace table creation When creating real tables with replace=false (non-truncate sync modes), use CREATE TABLE IF NOT EXISTS instead of CREATE TABLE to prevent errors when the table already exists. This complements the CDK change in #81549 which switched non-truncate modes to use replace=false. Co-authored-by: Claude <noreply@anthropic.com>
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
|
Note ✅ All modified connector(s) now have autopilot progressive rollouts enabled. Thanks! |
Upgrade CDK to 1.0.16 which includes the replace=false change (#81549) for non-truncate sync modes. Without this bump, the CREATE TABLE IF NOT EXISTS path would never be exercised. Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
|
Note Detected that there are differences in the Gradle dependencies. |
|
|
Deploy preview for airbyte-docs ready!
Deployed with vercel-action |
|
↪️ Triggering Reason: Ready non-draft fix PR with CI largely green and no prior AI review. Running AI review is the next pipeline stage. |
Reviewing PR for connector safety and quality.
|
🛡️ AI PR Review Report🔴 Review Action: REQUEST CHANGES
🔶 Risk Level: 3/5Behavioral change to existing table-creation DDL in 🔧 Remediation RequiredTest Coverage (enforced → REQUEST CHANGES)
Live / E2E Tests (UNKNOWN — not blocking, but recommended)
📋 PR DetailsConnector(s): 🔍 Gate Evaluation DetailsGate-by-Gate Analysis
Changed files (4):
📚 Evidence ConsultedEvidence
❓ How to RespondProviding Context or JustificationYou can add explanations that the bot will see on the next review: Option 1: PR Description (recommended) ## AI PR Review Justification
### Test Coverage
[Your explanation here]Option 2: PR Comment After adding your response, re-run Note: For Test Coverage, a sufficient justification (e.g. existing tests already cover the changed behavior, or the change is a trivial refactor) can flip FAIL → PASS. For the Live / E2E Tests gate, run |
|
/enable-autopilot-rollouts
|
Summary
CREATE TABLE IF NOT EXISTSinstead ofCREATE TABLEwhenreplace=falseinBigqueryDirectLoadSqlGeneratorreplace=falsePart of https://github.com/airbytehq/oncall/issues/13059
Supersedes #81550 (for BigQuery portion)
Important
⚡ Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.