✨ Support non-legacy keys via base64 encoding#40
Merged
Conversation
aisk
force-pushed
the
feat/base64-binary-keys
branch
from
091ed83 to
cdb35e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keys with whitespace, control chars or non-ASCII bytes broke the wire frame and crashed the hash-ring router.
Now such keys are base64-encoded with the meta
bflag at serialization time, whileMetaCommand.keykeeps the original key for routing. Keys over 250 bytes are rejected; routing decodes with latin-1 so binary keys never raise.