Configurable versions for gradle/kotlin/android plugin - #41
Conversation
|
Hi @jmfayard thanks, can you resolve the conflicts so we can merge it |
|
@borisf done |
| "buildscript {\n" + | ||
| (if (useKotlin) | ||
| " ext.kotlin_version = '1.1.51'\n" | ||
| else "")+ |
There was a problem hiding this comment.
removed it because it's already defined in the top build.gradle
no need to update it to a wrong version
| { | ||
| "projectName": "gennyCLI", | ||
| "root": "./modules/", | ||
| "androidGradleVersion": "3.0.1", |
There was a problem hiding this comment.
please name it "androidGradlePluginVersion"
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:3.0.0' | ||
| classpath 'com.android.tools.build:gradle:3.0.1' |
There was a problem hiding this comment.
Problem with customizing AGP version it that it is hardcoded here.
There was a problem hiding this comment.
is this file used?
if I set androidGradlePluginVersion to 3.0.0 I have only one reference as expected
$ egrep -ir 'com.android.tools.build:gradle' modules/gennyCLI
./build.gradle: classpath 'com.android.tools.build:gradle:3.0.0'
There was a problem hiding this comment.
This file was copied directly to the project folder, but after b8d5368#diff-469f26b37acf957d7e037aa3fc78cd01 this file is no longer used, I should have removed it on the same commit.
|
LGTM |
|
@jmfayard can you please resolve conflicts for us to merge |
New configurations available "gradleVersion": "4.3.1", "androidGradlePluginVersion": "3.0.1", "kotlinVersion": "1.1.60", Update README Refactor main class
|
@borisf conflicts resolved |
jmfayard
changed the title
4 participants
Hello, I wanted to fix indentation & update to Kotlin 1.1.60 ; android.gradle 3.0.1
In the meantime, I fixed the unit tests and clarified the main class
Update: the PR adds three parameters to the config