test: e2e tests for autoCsp#28701
Merged
Merged
Conversation
dgp1130
approved these changes
Oct 24, 2024
clydin
reviewed
Oct 24, 2024
aaronshim
force-pushed
the
auto-csp-e2e
branch
from
November 29, 2024 16:22
afb8d27 to
42160cf
Compare
aaronshim
force-pushed
the
auto-csp-e2e
branch
from
December 12, 2024 00:06
42160cf to
25e7dd0
Compare
dgp1130
approved these changes
Dec 12, 2024
dgp1130
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I wish we had a better mechanism for serving the built page and running the browser, but given the current state of our e2e infra I don't think we have a better option which doesn't pull on a lot of other complexity. Any concerns here @clydin?
clydin
approved these changes
Dec 12, 2024
Contributor
|
I assume |
Collaborator
|
Should be |
Contributor
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No e2e tests for #28663
Issue Number: N/A
What is the new behavior?
e2e tests for #28663
Does this PR introduce a breaking change?
Other information