fix(@angular/ssr): enable serving of prerendered pages in the App Engine#28737
Merged
Conversation
alan-agius4
force-pushed
the
serve-static
branch
7 times, most recently
from
October 29, 2024 15:58
065dcc5 to
27d92dd
Compare
alan-agius4
commented
Oct 29, 2024
alan-agius4
added
the
target: rc
alan-agius4
force-pushed
the
serve-static
branch
2 times, most recently
from
October 29, 2024 17:38
6f56cae to
f153cd1
Compare
alan-agius4
marked this pull request as ready for review
October 29, 2024 18:16
alan-agius4
removed
the
target: rc
dgp1130
reviewed
Oct 30, 2024
dgp1130
left a comment
dgp1130
left a comment
Collaborator
There was a problem hiding this comment.
Left a few comments, the two main concerns are whether we can simplify the API surface of AngularAppEngine and how we should let devs interact with the caching policy.
alan-agius4
force-pushed
the
serve-static
branch
2 times, most recently
from
October 31, 2024 08:44
94396da to
aa236be
Compare
dgp1130
approved these changes
Oct 31, 2024
dgp1130
left a comment
dgp1130
left a comment
Collaborator
There was a problem hiding this comment.
I gave some suggestions for the process, serve, render naming, but ultimately I'm happy to defer to you on what you think is best here.
alan-agius4
added
target: rc
alan-agius4
force-pushed
the
serve-static
branch
2 times, most recently
from
October 31, 2024 16:24
a9ab5e7 to
e640320
Compare
alan-agius4
force-pushed
the
serve-static
branch
2 times, most recently
from
October 31, 2024 16:50
1a6c78b to
b85f5d9
Compare
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
serve-static
branch
from
November 1, 2024 07:02
b85f5d9 to
3bfec99
Compare
This commit implements the capability for the App Engine to serve prerendered pages directly. Previously, we relied on frameworks like Express for this functionality, which resulted in inconsistent redirects for directories where in some cases a trailing slash was added to the route. **Note:** This change applies only when using the new SSR APIs. When using the `CommonEngine`, a 3rd party static serve middleware is still required.
alan-agius4
force-pushed
the
serve-static
branch
from
November 1, 2024 08:32
3bfec99 to
33dac61
Compare
Collaborator
Author
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the capability for the App Engine to serve prerendered pages directly. Previously, we relied on frameworks like Express for this functionality, which resulted in inconsistent redirects for directories where in some cases a trailing slash was added to the route.
Note: This change applies only when using the new SSR APIs. When using the
CommonEngine, a 3rd party static serve middleware is still required.