fix: use default import for express#28876
Merged
Merged
Conversation
dgp1130
added
action: review
Now that we're using `esModuleInterop`, a default import is required.
dgp1130
force-pushed
the
express-import
branch
from
November 15, 2024 23:48
722a084 to
b89aa82
Compare
dgp1130
added
target: rc
Collaborator
Author
|
Targeting RC for now, this might make sense for v18 projects or earlier, but we can backport later as needed. |
hybrist
approved these changes
Nov 16, 2024
dgp1130
added
action: merge
Contributor
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we're using
esModuleInterop, a default import is required.