build: update dependency @web/test-runner to v1#3837
Conversation
angular-robot
added
action: merge
![gemini-code-assist[bot]](https://cdn.github.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the @web/test-runner dependency from ^0.20.2 to ^1.0.0 in package.json along with its lockfile. The review feedback highlights a critical version mismatch, as @web/test-runner-core remains pinned to ^0.13.4. This discrepancy can lead to runtime errors or communication failures because the test runner will serve an outdated browser session script. It is recommended to align both packages to version ^1.0.0.
| "@web/test-runner": "^1.0.0", | ||
| "@web/test-runner-core": "^0.13.4", |
There was a problem hiding this comment.
Updating @web/test-runner to ^1.0.0 while leaving @web/test-runner-core at ^0.13.4 introduces a critical version mismatch.
Specifically, in wtr.config.mjs, the configuration reads the browser session script directly from the file system:
'../node_modules/@web/test-runner-core/browser/session.js'Because @web/test-runner-core is pinned to ^0.13.4 in package.json, pnpm will install the old v0.13.4 version at the top-level node_modules. This means the test runner (running v1.0.0) will serve the old v0.13.4 session script to the browser, which is highly likely to cause runtime errors or communication failures.
Please update @web/test-runner-core to ^1.0.0 to ensure version alignment. You should also consider updating @web/dev-server-rollup and @web/test-runner-puppeteer to their corresponding major versions to avoid other potential incompatibilities.
| "@web/test-runner": "^1.0.0", | |
| "@web/test-runner-core": "^0.13.4", | |
| "@web/test-runner": "^1.0.0", | |
| "@web/test-runner-core": "^1.0.0", |
See associated pull request for more information.
224853b to
0c1f4d4
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
2 participants
This PR contains the following updates:
^0.20.2→^1.0.0Release Notes
modernweb-dev/web (@web/test-runner)
v1.0.0Compare Source
Major Changes
5260164: Drop support for Node.js 18 and 20, which have reached end-of-life. The minimum supported Node.js version is now 22.0.0.The Node code is compiled to ES2024 which is aligned with the Node 22.
Patch Changes
5260164]8fe1b90]