fix(server): treat undefined origin as non-CORS, reject empty origin string - #39109
Closed
AAliKKhan wants to merge 1 commit into
Closed
fix(server): treat undefined origin as non-CORS, reject empty origin string#39109AAliKKhan wants to merge 1 commit into
AAliKKhan wants to merge 1 commit into
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39108
Type of change
What does this PR do?
Both
isAllowedCorsOriginandisAllowedRequestOriginusedif (!input) return trueto handle missing Origin headers. The!inputcoercion treats an empty string""the same asundefined, so clients sending an emptyOrigin:header bypass all CORS checks.Fix: use
input === undefinedso only the absence of the header is treated as a non-CORS request. An empty origin string falls through to the normal validation and gets correctly rejected.How did you verify your code works?
Checked the call sites in pty.ts where
request.headers.origincan bestring | undefined. An empty string now hits the.startsWith()checks which all return false, so the request is properly rejected.Checklist