fix: honor thumbs-down from any user when skipping duplicate auto-close - #79151
Open
Codeturion wants to merge 1 commit into
Open
fix: honor thumbs-down from any user when skipping duplicate auto-close#79151Codeturion wants to merge 1 commit into
Codeturion wants to merge 1 commit into
Conversation
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dedupe bot comment promises "To prevent auto-closure, add a comment or 👎 this comment" with no author qualifier (
scripts/comment-on-duplicates.sh:89), butauto-close-duplicates.tsonly counts a-1reaction from the issue author, so anyone else's thumbs-down is ignored and the issue still auto-closes. The comment path already blocks on activity from any user, so this PR makes the reaction path consistent: any user's-1on the dupe comment skips auto-closure. No new abuse surface, since anyone can already block closure by commenting.Files changed
scripts/auto-close-duplicates.ts(reaction predicate and its debug logs, lines 228-241)Verification
Setup: repro script that slices the actual
.some(...)predicate out of a given copy of the file and evaluates it against fixture reaction sets (author-1, non-author-1, non-author+1, none). Typecheck with tsc 7.0.2 (--strict, es2022+dom libs) on both versions.Details: ran the predicate harness and typecheck against upstream main and this branch on macOS/node. Both versions typecheck clean; behavior differs only in the non-author
-1case.Comparisons
If author-only was intentional, the alternative is rewording the bot comment; happy to switch to that if preferred.
Refs
Fixes #79146