docs: fix security-guidance plugin entry in plugins/README.md - #81576
Open
Woohyeon-Hong wants to merge 1 commit into
Open
docs: fix security-guidance plugin entry in plugins/README.md#81576Woohyeon-Hong wants to merge 1 commit into
Woohyeon-Hong wants to merge 1 commit into
Conversation
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/README.md's security-guidance entry claims a singlePreToolUsehook monitoring 9 security patterns. Neither claim holds: the plugin has noPreToolUsehook, and its pattern list has 25 entries, not 9. The entry also collapses three functionally distinct triggers (regex warnings, an agentic multi-file review on commit/push, and a full-diff review on Stop) into one line. This PR rewrites the entry to match the actual hooks.json registration.Files changed
plugins/README.md(line 27)Verification
Setup: fresh checkout of main; compared the table entry against
plugins/security-guidance/hooks/hooks.jsonandplugins/security-guidance/hooks/patterns.py.Details:
hooks.jsonhas noPreToolUsekey; it registersSessionStart,UserPromptSubmit,PostToolUse(two matcher groups —Edit|Write|MultiEdit|NotebookEdit, andBashwithif: git commit/push), andStop.patterns.py'sSECURITY_PATTERNSlist has 25 dicts with a"ruleName"key (lines 32-255); a naivegrep -c '"ruleName"'returns 26 because of an unrelated assert at line 330 that also references the key.Comparisons
PreToolUsekey anywherePostToolUse/Stop"ruleName"entries inSECURITY_PATTERNSgit commit/git push(PostToolUse, Bash matcher)Refs
Fixes #81573