Skip to content

GH-588: [Release] Increase wait interval in dev/release/release_rc.sh #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Feb 6, 2025
Merged

GH-588: [Release] Increase wait interval in dev/release/release_rc.sh #589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/release/release_rc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,13 @@ if [ "${RELEASE_SIGN}" -gt 0 ]; then
if [ -n "${run_id}" ]; then
break
fi
sleep 60
sleep 600

@lidavidm lidavidm Feb 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait 10 minutes!?

@jbonofre jbonofre Feb 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's a sleep, it seems so. It's maybe related to @kou network. 10mn is OK though is necessary.

@lidavidm lidavidm Feb 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the issue explains the whole process takes ~30 minutes so ~10 minutes seems reasonable (I guess Github doesn't like pinging too often)

@jbonofre jbonofre Feb 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's pretty clear regarding #588 (comment)

@kou kou Feb 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
I've added it to this PR description too. Sorry. I should have explained it in the PR description too.

done

echo "Found GitHub Actions workflow with ID: ${run_id}"
gh run watch \
--exit-status "${run_id}" \
--interval 60 \
--interval 600 \
--repo "${repository}"

echo "Downloading artifacts from GitHub Releases"
Expand Down