fix: Resolve TS2352 type error in MapBuilder for TypeScript 5.6+#373
Merged
Conversation
Contributor
Author
|
@kou I’ve fixed the issue. Could you please merge it? |
kou
changed the title
There was a problem hiding this comment.
Pull request overview
Resolves a TypeScript 5.6+ TS2352 type conversion error in MapBuilder.setValue() caused by stricter casting checks.
Changes:
- Updates the
rowtype assertion to use an intermediateunknowncast to satisfy TS 5.6+ rules. - Removes an unnecessary type assertion on
pending.get(index)and relies on inferred typing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Hi @kou , Could you please let me know if any changes are required for this issue? |
trxcllnt
approved these changes
Feb 3, 2026
Member
|
I was waiting for reviews from Apache Arrow JS maintainers. Now, we have an approval. I merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Fixed TS2352 type conversion error in MapBuilder.setValue() that occurs with TypeScript 5.6+ due to stricter type checking.
Changes
Updated type assertion in [map.ts] to use intermediate unknown cast (as unknown as MapValue<K, V>) to satisfy TypeScript 5.6+ stricter type narrowing
Removed unnecessary type assertion on pending.get(index) since the type is already inferred correctly
Why
TypeScript 5.6 introduced stricter type conversion rules, causing TS2352 errors when directly casting between incompatible types. The as unknown as T pattern is the recommended approach for these scenarios.
This is a non-breaking change - it only affects compile-time behavior and has no runtime impact.
Closes #49 .