[CI][Dev] Use pre-commit for IWYU

[kou]

Describe the enhancement requested

Is IWYU check needed?

Our CI disables IWYU check:

arrow/docker-compose.yml

Line 1927 in d3b90c3

archery lint --all --no-clang-tidy --no-iwyu --no-numpydoc --src /arrow"

Component(s)

Continuous Integration, Developer Tools

[pitrou]

Everytime I've tried to use IWYU, it produced a ton of spurious errors or changes. But that was years ago, perhaps things have improved?

In any case, I don't think it was ever enabled on CI.

[kou]

Do we enable IWYU on CI in the feature?

[pitrou]

Not before we ensure that it produces good results locally, IMHO.

[WillAyd]

I have a similar experience as @pitrou more recently where the tool seems to provide strange feedback. In some cases, iwyu ends up creating a loop where it constantly tells me to add/remove the same files...so I'm not sure how usable it would be as a pre-commit check

[kou]

OK. Let's defer this.

We'll remove archery lint before we add support IWYU to our pre-commit configuration.

[github-actions]

This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.