Skip to content

GH-44831: [CI] Build Java for integration tests from arrow-java#44932

Merged
kou merged 1 commit into
apache:mainfrom
lidavidm:gh-44831
Dec 5, 2024
Merged

GH-44831: [CI] Build Java for integration tests from arrow-java#44932
kou merged 1 commit into
apache:mainfrom
lidavidm:gh-44831

Conversation

@lidavidm

@lidavidm lidavidm commented Dec 4, 2024

Copy link
Copy Markdown
Member

Rationale for this change

We moved java/ in apache/arrow to apache/arrow-java. We should use apache/arrow-java to integration tests.

What changes are included in this PR?

  • Remove java/
  • Use apache/arrow-java for integration test

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@lidavidm

lidavidm commented Dec 4, 2024

Copy link
Copy Markdown
Member Author

We can't actually merge this until we finish deleting the rest of the existing Java code here.

@lidavidm

lidavidm commented Dec 4, 2024

Copy link
Copy Markdown
Member Author

It seems integration works...

@lidavidm
lidavidm marked this pull request as ready for review December 4, 2024 10:31
@lidavidm

lidavidm commented Dec 4, 2024

Copy link
Copy Markdown
Member Author

We...may not want to merge this as-is, but it passes tests!

This was referenced Dec 5, 2024
@lidavidm

lidavidm commented Dec 5, 2024

Copy link
Copy Markdown
Member Author

Updated, I think the macOS issue is not related.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 8ac434f into apache:main Dec 5, 2024
@kou kou removed the awaiting committer review Awaiting committer review label Dec 5, 2024
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Dec 5, 2024
@lidavidm
lidavidm deleted the gh-44831 branch December 5, 2024 07:56
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8ac434f.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] Remove java/ [Java][CI] Use apache/arrow-java for integration test

2 participants