GH-46582: [Docs] Update docs to match main site and link to other repos#46583
Conversation
|
@github-actions crossbow submit preview-docs |
|
|
|
|
|
Revision: 32a0081 Submitted crossbow builds: ursacomputing/crossbow @ actions-d1602bad04
|
|
@github-actions crossbow submit preview-docs |
|
Revision: a4160a6 Submitted crossbow builds: ursacomputing/crossbow @ actions-b81b26dbb9
|
|
@ianmcook It's not possible to add "docs" and "source" dropdowns like on the main site using the current template, but I tried a different approach here to simplify the landing page. Let me know what you think. |
|
@github-actions crossbow submit preview-docs |
|
Revision: a2c2b17 Submitted crossbow builds: ursacomputing/crossbow @ actions-5ae03d6066
|
|
I really like this approach; thanks @thisisnic! I'll add some comments later today. |
github-actions
Bot
added
awaiting changes
AlenkaF
left a comment
AlenkaF
left a comment
There was a problem hiding this comment.
Thanks for the changes! This will make the docs nicer to move through.
github-actions
Bot
added
awaiting change review
|
@github-actions crossbow submit preview-docs |
|
Revision: 2973b9c Submitted crossbow builds: ursacomputing/crossbow @ actions-15d60c8255
|
|
Thanks both for the feedback! I've renamed the heading back to "implementations" and for simplicity have moved those details back to the landing page. |
|
My 2 cents: I thought it was very nice having the table of Arrow implementations on their own separate page, like @thisisnic had in an earlier commit in this PR. But I understand your wish to keep the list of languages featured prominently on the main index page @AlenkaF. I think there's a good way to reconcile this: How about we add two more cards to the grid on the main index page, so it looks like this? 
The Implementations link/button will go to a separate page (like Nic had before, but named "Implementations" instead of "Libraries"). The Cookbook button will link to the cookbooks page. @thisisnic if you give me commit rights for your fork, I can push this. |
|
You should be able to push to this but let me know if you can't @ianmcook! |
|
@github-actions crossbow submit preview-docs |
|
Revision: 0d1ffc6 Submitted crossbow builds: ursacomputing/crossbow @ actions-7e6f2ccd9e
|
|
@github-actions crossbow submit preview-docs |
|
Revision: 2e4b26f Submitted crossbow builds: ursacomputing/crossbow @ actions-ce353801d3
|
|
@AlenkaF let us know if this looks good to you! |
github-actions
Bot
added
awaiting merge
AlenkaF
left a comment
AlenkaF
left a comment
There was a problem hiding this comment.
LGTM with only one last suggestion!
| * - nanoarrow | ||
| - `nanoarrow Docs <https://arrow.apache.org/nanoarrow>`_ | ||
| - `nanoarrow Source <http://github.com/apache/arrow-nanoarrow>`_ | ||
|
|
There was a problem hiding this comment.
Could we add a section for the Cookbooks here as well? It would be helpful to make them accessible from multiple locations.
| C++ cookbook <https://arrow.apache.org/cookbook/cpp/> | |
| Java cookbook <https://arrow.apache.org/cookbook/java/> | |
| Python cookbook <https://arrow.apache.org/cookbook/py/> | |
| R cookbook <https://arrow.apache.org/cookbook/r/> |
As a list-table or as a normal list, not sure.
|
@github-actions crossbow submit preview-docs |
|
Revision: 7d050b7 Submitted crossbow builds: ursacomputing/crossbow @ actions-2119246738
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d7015bd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
3 participants
Rationale for this change
Updating docs site to more easily link to other repos
What changes are included in this PR?
Docs updates
Are these changes tested?
Nope
Are there any user-facing changes?
To the docs, aye