Skip to content

ARROW-12194: [Rust][Parquet] Bump zstd to v0.7 - #9881

Closed
aldanor wants to merge 1 commit into
apache:masterfrom
aldanor:feature/zstd-0.7
Closed

ARROW-12194: [Rust][Parquet] Bump zstd to v0.7#9881
aldanor wants to merge 1 commit into
apache:masterfrom
aldanor:feature/zstd-0.7

Conversation

@aldanor

@aldanor aldanor commented Apr 3, 2021

Copy link
Copy Markdown
Contributor

This updates zstd version used by parquet crate to zstd = "0.7.0+zstd.1.4.9".

@github-actions

github-actions Bot commented Apr 3, 2021

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #9881 (f157708) into master (5bfae36) will increase coverage by 0.07%.
The diff coverage is 90.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9881      +/-   ##
==========================================
+ Coverage   82.60%   82.68%   +0.07%     
==========================================
  Files         255      256       +1     
  Lines       59674    60105     +431     
==========================================
+ Hits        49295    49699     +404     
- Misses      10379    10406      +27     
Impacted Files Coverage Δ
rust/arrow-pyarrow-integration-testing/src/lib.rs 0.00% <ø> (ø)
rust/arrow/src/datatypes/field.rs 55.47% <0.00%> (ø)
rust/arrow/src/error.rs 11.11% <0.00%> (-0.52%) ⬇️
rust/arrow/src/ipc/writer.rs 86.70% <0.00%> (-0.74%) ⬇️
rust/datafusion/src/logical_plan/expr.rs 83.39% <ø> (ø)
rust/parquet/benches/arrow_writer.rs 0.00% <0.00%> (ø)
rust/datafusion/src/scalar.rs 51.22% <33.33%> (-0.15%) ⬇️
.../datafusion/src/physical_plan/regex_expressions.rs 86.15% <60.00%> (-2.18%) ⬇️
rust/arrow/src/array/ffi.rs 85.13% <83.33%> (-4.23%) ⬇️
rust/datafusion/src/catalog/information_schema.rs 88.78% <89.40%> (+4.05%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d87a0e...f157708. Read the comment docs.

@Dandandan Dandandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@alamb
alamb force-pushed the feature/zstd-0.7 branch from f157708 to d9a3500 Compare April 3, 2021 17:43

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aldanor ! I took the liberty of rebasing this PR against apache master to pick up #9879? I think that should fix the CI failures on this PR

Once we get a clean run I'll mege it in

@aldanor

aldanor commented Apr 3, 2021

Copy link
Copy Markdown
Contributor Author

@alamb 👍

@alamb alamb changed the title [Rust][Parquet] Bump zstd to v0.7 ARROW-12194: [Rust][Parquet] Bump zstd to v0.7 Apr 4, 2021
@alamb alamb closed this in ebe4295 Apr 4, 2021
@github-actions

github-actions Bot commented Apr 4, 2021

Copy link
Copy Markdown

@alamb

alamb commented Apr 4, 2021

Copy link
Copy Markdown
Contributor

Thanks again @aldanor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants