Skip to content

PHP - fix json_decode syntax error and set dev tools version - #3824

Merged
mattiabasone merged 1 commit into
apache:mainfrom
mattiabasone:fix-php-ci-and-patch-reported-error
Jun 19, 2026
Merged

PHP - fix json_decode syntax error and set dev tools version#3824
mattiabasone merged 1 commit into
apache:mainfrom
mattiabasone:fix-php-ci-and-patch-reported-error

Conversation

@mattiabasone

@mattiabasone mattiabasone commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Fix error reported by static analysis tool (phpstan)

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@github-actions github-actions Bot added the PHP label Jun 19, 2026
@mattiabasone mattiabasone changed the title fix error and tool version PHP - fix error and set dev tools version Jun 19, 2026
@mattiabasone mattiabasone changed the title PHP - fix error and set dev tools version PHP - fix json_decode syntax error and set dev tools version Jun 19, 2026
@mattiabasone
mattiabasone merged commit 840dc81 into apache:main Jun 19, 2026
22 checks passed
@martin-g

Copy link
Copy Markdown
Member

Thank you, @mattiabasone !

@RyanSkraba

RyanSkraba commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Thanks! Is this something that needs to be cherry-picked to branch-1.12?

@mattiabasone

Copy link
Copy Markdown
Contributor Author

Thanks! Is this something that needs to be cherry-picked to branch-1.12?

Yes, please 🙂

@RyanSkraba

Copy link
Copy Markdown
Contributor

Hello! I couldn't cherry-pick this because of merge conflicts -- do you want to give it a try or does it need to be rewritten for 1.12?

@mattiabasone

Copy link
Copy Markdown
Contributor Author

Hello! I couldn't cherry-pick this because of merge conflicts -- do you want to give it a try or does it need to be rewritten for 1.12?

I've checked again the 1.12 branch, but it doesn't include the errors becuse the php source code is still outdated. @RyanSkraba is it probably related to the revert of this PR which added my recent changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants