[Gemini] Add Java GeminiModelHandler class#39245
Conversation
|
@gemini-code-assist review |
![gemini-code-assist[bot]](https://cdn.github.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Gemini model handler module (sdks/java/ml/inference/gemini) for remote inference in Apache Beam, alongside generic type updates to the remote inference base classes to support arbitrary input and output types. Feedback on the changes focuses on improving the robustness and flexibility of the implementation. Key recommendations include enabling default client initialization via environment variables, adding defensive null and empty-list checks in GeminiModelHandler, removing the unused getUseVertexFlexApi parameter, updating unit tests accordingly, and removing the temporary TestReflection debugging utility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new Gemini model handler to the Apache Beam Java SDK, allowing users to call Gemini models directly from Java pipelines. It also includes necessary refactoring in the remote inference module to improve type flexibility and updates the build configuration to include the new module. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Test failures are all unrelated on master |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @Abacn |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @ahmedabu98 for label java. Available commands:
|
| * </ul> | ||
| */ | ||
| public interface BaseModelHandler< | ||
| ParamT extends BaseModelParameters, InputT extends BaseInput, OutputT extends BaseResponse> { |
There was a problem hiding this comment.
Changing base class signatures sound an overreach unless intentional. Please confirm or we should add them back.
There was a problem hiding this comment.
This was an unintended side effect of trying to remove some weird UX around coders, fixed.
|
|
||
| applyJavaNature( | ||
| automaticModuleName: 'org.apache.beam.sdk.ml.inference.gemini', | ||
| requireJavaVersion: JavaVersion.VERSION_11 |
There was a problem hiding this comment.
Remove "requireJavaVersion: JavaVersion.VERSION_11"
|
|
||
| /** Functional interface for custom request functions to the Gemini API. */ | ||
| @FunctionalInterface | ||
| public interface GeminiRequestFunction<InputT, OutputT> extends Serializable { |
There was a problem hiding this comment.
Consider using extends org.apache.beam.sdk.transforms.SerializableFunction?
There was a problem hiding this comment.
Using the SerializableFunction is a little annoying since we'd have to wrap the args to the current signature (model name, batch, client) into a singular object. We also expect the client to potentially raise checked exceptions in the request-response loop (like raising HTTP 429 errors to trigger our client-side throttling) which gets more complicated when SerializableFunction's apply method doesn't throw checked exceptions.
2 participants
Adds a Java implementation of the GeminiModelHandler, using the Java GenAI SDK to allow calling Gemini models from Java pipelines without cross-language usage.
Fixes #36253
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.