test: cover ArrayExists three-valued logic config#5000
Open
manuzhang wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codex <codex@openai.com>
Contributor
|
might be related to #4799 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to apache/datafusion-comet#4180.
Rationale for this change
spark.sql.legacy.followThreeValuedLogicInArrayExistschanges the result ofexistswhen no predicate result is true and at least one result is null. The existing SQL test did not exercise that divergent behavior under both configuration values, and result comparison alone did not directly assert that the JVM codegen dispatcher ran.What changes are included in this PR?
expressions/array/exists.sqlwith both values ofspark.sql.legacy.followThreeValuedLogicInArrayExists.ArrayExistsunder both config values insideassertCodegenRanandcheckSparkAnswerAndOperator, so silent fallback to Spark fails the test.How are these changes tested?
make coreCometSqlFileTestSuite existsmatrix on Spark 3.4.3, 3.5.8, 4.0.2, and 4.1.2: both configuration cases passed on every profile.CometCodegenHOFSuiteon Spark 3.4.3, 3.5.8, 4.0.2, and 4.1.2: 5 tests passed on every profile.sphinx-buildis not installed locally.git diff --checkorg.scalameta:semanticdb-scalac_2.13.17:4.13.6artifact; the commit was amended with--no-verifyafter the focused cross-version tests above passed.