allow range to satisfy key distribution generally - #23680
Merged
Conversation
github-actions
Bot
added
physical-expr
gene-bordegaray
force-pushed
the
gene.bordegaray/2026/07/allow_range_to_satisfy_key_distribution_generally
branch
from
July 21, 2026 18:35
de0572d to
7df0261
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23680 +/- ##
==========================================
- Coverage 80.71% 80.71% -0.01%
==========================================
Files 1089 1089
Lines 368748 368741 -7
Branches 368748 368741 -7
==========================================
- Hits 297633 297614 -19
- Misses 53372 53374 +2
- Partials 17743 17753 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gene-bordegaray
marked this pull request as ready for review
July 21, 2026 19:55
Contributor
Author
|
cc: @gabotechs |
gene-bordegaray
changed the title
26 tasks
gabotechs
approved these changes
Jul 22, 2026
gene-bordegaray
force-pushed
the
gene.bordegaray/2026/07/allow_range_to_satisfy_key_distribution_generally
branch
from
July 22, 2026 14:34
7df0261 to
b173254
Compare
gene-bordegaray
force-pushed
the
gene.bordegaray/2026/07/allow_range_to_satisfy_key_distribution_generally
branch
from
July 22, 2026 20:34
b173254 to
03518df
Compare
gabotechs
approved these changes
Jul 23, 2026
gabotechs
left a comment
gabotechs
left a comment
Contributor
There was a problem hiding this comment.
Nice ✂️, thanks @gene-bordegaray!
gene-bordegaray
added a commit
to gene-bordegaray/datafusion
that referenced
this pull request
Jul 24, 2026
<!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#23266. - Part of apache#22395. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> `Partitioning::Range` now satisfies `Distribution::KeyPartitioned` privately across all operators that require it: aggregates, windows, TopK, and co-partitioned joins. So now the temporary operator opt-ins can be consolidated. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - Allow compatible `Partitioning::Range` to satisfy `Distribution::KeyPartitioned` via `Partitioning::satisfaction` - Remove the temporary range-satisfaction helpers and operator-specific opt-ins <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No, this should not change any exisitng behavior just consolidation <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partitioning::Rangeto satisfyDistribution::KeyPartitionedgenerally #23266.Rationale for this change
Partitioning::Rangenow satisfiesDistribution::KeyPartitionedprivately across all operators that require it: aggregates, windows, TopK, and co-partitioned joins. So now the temporary operator opt-ins can be consolidated.What changes are included in this PR?
Partitioning::Rangeto satisfyDistribution::KeyPartitionedviaPartitioning::satisfactionAre these changes tested?
Yes
Are there any user-facing changes?
No, this should not change any exisitng behavior just consolidation