Skip to content

[MINOR]: Add new test for filter pushdown into cross join - #8648

Merged
ozankabak merged 5 commits into
apache:mainfrom
synnada-ai:minor/filter_pushdown_subs
Dec 25, 2023
Merged

[MINOR]: Add new test for filter pushdown into cross join#8648
ozankabak merged 5 commits into
apache:mainfrom
synnada-ai:minor/filter_pushdown_subs

Conversation

@mustafasrepo

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

There are couple of missing points in the [PR](Subsequent PR of 8626). This PR add these missing points. See discussion for rationale

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

@github-actions github-actions Bot added optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) labels Dec 25, 2023
@mustafasrepo mustafasrepo changed the title [MINOR]: Subsequent PR of [8626](https://github.com/apache/arrow-datafusion/pull/8626) [MINOR]: Add new test for filter pushdown into cross join Dec 25, 2023
@mustafasrepo
mustafasrepo requested a review from viirya December 25, 2023 13:19
Comment thread datafusion/sqllogictest/src/test_context.rs Outdated
@viirya

viirya commented Dec 25, 2023

Copy link
Copy Markdown
Member

Thank you @mustafasrepo for addresses these points.

@ozankabak
ozankabak merged commit ec8fd44 into apache:main Dec 25, 2023
appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Jan 4, 2024
* Initial commit

* Minor changes

* Simplifications

* Update UDF example

* Address review

---------

Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants