fix: preserve DimensionValueSetShardSpec on upgraded append segments#19615
Merged
abhishekrb19 merged 1 commit intoJun 22, 2026
Merged
Conversation
When a concurrent REPLACE upgrades a still-appending streaming task, the upgraded (new-version) copy of each append segment previously adopted the pending segment's plain NumberedShardSpec, dropping the DimensionValueSetShardSpec stamped at publish time. This made upgraded segments unprunable by the broker. The upgraded copy now takes its partition number and core-partition count from the pending segment while carrying forward the original segment's partitionDimensionValues when it is a DimensionValueSetShardSpec. The value-set guarantee holds because the upgraded copy serves the same rows as the original append segment.
aho135
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #19571, when a concurrent replace task
upgrades a still-appending streaming task, the upgraded (new-version) copy of
each append segment previously adopted the pending segment's plain NumberedShardSpec,
dropping the DimensionValueSetShardSpec stamped at publish time. This made upgraded
segments unprunable by the broker.
The upgraded copy now takes its partition number and core-partition count
from the pending segment while carrying forward the original segment's
partitionDimensionValues when it is a DimensionValueSetShardSpec. The
value-set guarantee holds because the upgraded copy serves the same rows
as the original append segment.
This does not change the fact that pending segments are always allocated as numbered
shard specs, since tasks still advertise them as such — the value-set shard spec
currently applies only to recently-published segments.
This PR has: