[server] Fix tmp file cleanup in remote log index cache init#3755
Open
fresh-borzoni wants to merge 1 commit into
Open
[server] Fix tmp file cleanup in remote log index cache init#3755fresh-borzoni wants to merge 1 commit into
fresh-borzoni wants to merge 1 commit into
Conversation
fresh-borzoni
force-pushed
the
remote-index-cache-tmp-cleanup
branch
from
July 23, 2026 17:06
62e60c9 to
7e38705
Compare
fresh-borzoni
force-pushed
the
remote-index-cache-tmp-cleanup
branch
from
July 23, 2026 17:08
7e38705 to
1fa430b
Compare
Member
Author
|
@zuston Can you help to review, please? |
zuston
approved these changes
Jul 24, 2026
zuston
left a comment
zuston
left a comment
Member
There was a problem hiding this comment.
nice catch! LGTM. @fresh-borzoni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3754
The .tmp cleanup in RemoteLogIndexCache.init() never fires, Path.endsWith(".tmp") compares path elements, not filename suffixes. Use the filename string instead, so orphaned partial downloads are actually deleted on startup.