HBASE-28774: Protect hbase:meta from any hotspotting regions by balancing them to different region servers - #6173
Draft
ranganathg wants to merge 4 commits into
Draft
HBASE-28774: Protect hbase:meta from any hotspotting regions by balancing them to different region servers#6173ranganathg wants to merge 4 commits into
ranganathg wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ranganathg
force-pushed
the
HBASE-28774
branch
from
August 22, 2024 13:34
b756ee1 to
a3d4d0a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ranganathg
marked this pull request as ready for review
August 22, 2024 14:57
mnpoonia
reviewed
Aug 23, 2024
|
|
||
| Map<ServerName, List<RegionInfo>> clusterState = this.cluster.clusterState; | ||
|
|
||
| for (Map.Entry<ServerName, List<RegionInfo>> entry : clusterState.entrySet()) { |
Contributor
There was a problem hiding this comment.
Let us add comment about what we are doing and how it would impact the balancer decision with an example.
ranganathg
marked this pull request as draft
August 23, 2024 08:06
ranganathg
force-pushed
the
HBASE-28774
branch
from
August 23, 2024 10:36
a3d4d0a to
e05d406
Compare
ranganathg
force-pushed
the
HBASE-28774
branch
from
August 23, 2024 10:43
e05d406 to
e0ac33a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| * on same RS | ||
| */ | ||
| @InterfaceAudience.Private public class MutuallyExclusiveTablesCostFunction extends CostFunction { | ||
| public static final String MUTUALLY_EXCLUSIVE_TABLES_KEY = |
Contributor
There was a problem hiding this comment.
NIT: good to add comments for config.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-28774
The idea is to provide a configuration where by one can configure mutually exclusive tables. For example: hbase:meta,SYSTEM.CATALOG can be mutually exclusive tables. Anytime these 2 tables come together the new plan will be costly and would need a rebalancing.