fix: reject non-finite floating-point default values#810
Open
huan233usc wants to merge 2 commits into
Open
Conversation
evindj
approved these changes
Jul 5, 2026
evindj
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me. For my own understanding how is the caller supposed to handle this error?
zhjwpku
reviewed
Jul 5, 2026
Collaborator
|
I think java impl has the same issue, created a PR to strict the validation apache/iceberg#17106 |
Contributor
Author
|
@evindj thanks for the review! |
zhjwpku
approved these changes
Jul 6, 2026
wgtmac
approved these changes
Jul 11, 2026
huan233usc
force-pushed
the
fix/reject-nan-inf-default
branch
from
July 12, 2026 21:32
93a5aa5 to
07af265
Compare
Contributor
Author
|
Hi @wgtmac, do you mind taking another look at this PR? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
float/doublecolumn default ofNaNor±InfinitypassesSchemaField::Validatebut cannot survive a metadata round-trip: the JSON serializer emits a non-finite number asnull, which reads back as an absent default. The declared default is silently lost (and, because the key is present but null, the reader then errors on it).How
ValidateDefaultnow rejects a non-finite floating default with a clear "value must be finite" error, so an unrepresentable default is caught up front rather than silently dropped on serialization.The check uses
std::isfinite, which is false for bothNaNand±Infinity— so a single condition covers all three cases (there is no separateIsNaNbranch becauseisfinitealready rejects NaN).Testing
SchemaFieldTest.ValidateRejectsNonFiniteFloatingDefaultexplicitly coversNaN,+Infand-Inf, andValidateAcceptsFiniteFloatingDefaultcovers a normal value; verified fail-without / pass-with. Fullschema_testpasses (551 tests).