[Append Scan] Extract manifest group planning into separate class - #2232
Closed
smaheshwar-pltr wants to merge 1 commit into
Closed
[Append Scan] Extract manifest group planning into separate class#2232smaheshwar-pltr wants to merge 1 commit into
smaheshwar-pltr wants to merge 1 commit into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Split up from incremental append scan work - see #2031 (comment). PyIceberg doesn't support incremental reading of appended data between snapshots, like Spark does.
This PR introduces a
ManifestGroupPlannerto hold the logic of using manifests to plan the files for a table scan. This allows this logic to be re-used across scans. TheIncrementalAppendScanwill also use this (see #2234).Are these changes tested?
N / A
Are there any user-facing changes?
Yes, see #2232 (comment).