Cache projectsUsingPlugin to fix O(N²) reactor scan - #427
Open
gnodet wants to merge 1 commit into
Open
Conversation
InstallMojo.execute() computes the list of reactor projects using the install plugin on every module invocation by streaming over all projects and calling getPluginsAsMap() for each one. In a 4383-module reactor, this produces ~19.2M filter evaluations (4383² calls). JFR profiling shows this as 5.6% of total CPU time, all in PluginContainer.getPluginsAsMap() called from usingPlugin(). Fix: cache the computed list in the first reactor project's plugin context on first invocation. The list is invariant during a build — which projects have the install plugin configured does not change between module invocations. This turns O(N²) into O(N). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
projectsUsingPluginlist in the first reactor project's plugin context on first invocationProblem
InstallMojo.execute()computessession.getProjects().stream().filter(this::usingPlugin).collect(toList())on every module invocation.usingPlugin()callsgetPluginsAsMap()for each project. In a 4383-module reactor, this produces ~19.2M filter evaluations (4383²).JFR profiling shows this pattern as 5.6% of total CPU time, all in
PluginContainer.getPluginsAsMap().Test plan
🤖 Generated with Claude Code