Skip to content

HDDS-12035. Enable sortpom in hadoop-hdds hadoop-dependency server & test - #7659

Merged
adoroszlai merged 1 commit into
apache:masterfrom
nandakumar131:HDDS-12035
Jan 7, 2025
Merged

HDDS-12035. Enable sortpom in hadoop-hdds hadoop-dependency server & test#7659
adoroszlai merged 1 commit into
apache:masterfrom
nandakumar131:HDDS-12035

Conversation

@nandakumar131

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Enable sortpom in hadoop-hdds hadoop-dependency server & test

Sortpom plugin was added as part of #7555.
This PR enables the plugin for hadoop-hdds sub-modules. (part 4)
Sorting all the sub-modules under hadoop-hdds creates a big change, which will be hard to review. So, breaking this into multiple PRs.
This PR sorts pom of the following sub-modules.

hadoop-dependency-server
hadoop-dependency-test

What is the link to the Apache JIRA

HDDS-12035

How was this patch tested?

Manually tested by adding out of order property.

hadoop-hdds/hadoop-dependency-server/pom.xml

[INFO] --- sortpom:3.0.1:verify (default) @ hdds-hadoop-dependency-server ---
[INFO] Verifying file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/hadoop-dependency-server/pom.xml
[ERROR] The line 31 is not considered sorted, should be '    <property.one>one</property.one>'
[ERROR] The file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/hadoop-dependency-server/pom.xml is not sorted

``hadoop-hdds/hadoop-dependency-test/pom.xml`

[INFO] --- sortpom:3.0.1:verify (default) @ hdds-hadoop-dependency-test ---
[INFO] Verifying file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/hadoop-dependency-test/pom.xml
[ERROR] The line 31 is not considered sorted, should be '    <property.one>one</property.one>'
[ERROR] The file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/hadoop-dependency-test/pom.xml is not sorted

@adoroszlai adoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nandakumar131 for the patch.

@adoroszlai
adoroszlai merged commit 984027c into apache:master Jan 7, 2025
@nandakumar131

Copy link
Copy Markdown
Contributor Author

Thanks @adoroszlai for the review and merge!

@nandakumar131
nandakumar131 deleted the HDDS-12035 branch January 8, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants