Introduces a new LogicalType: FILE#585
Conversation
emkornfield
left a comment
There was a problem hiding this comment.
Looks reasonable to me a few minor comments for clarification.
etseidl
left a comment
There was a problem hiding this comment.
Just a few questions I have after reviewing the Rust implementation.
rdblue
left a comment
There was a problem hiding this comment.
I left a few comments for clarification, but I think that this is ready either way.
|
@rdblue @wgtmac @mapleFU @RussellSpitzer Thank you for the feedback! Addressed your comments. Hopefully things are clearer now! Let me know if they aren't |
…@ 90147dc) Align with the latest apache/parquet-format#585 (commit 90147dc): - path is now a URI-reference per RFC 3986 (absolute or relative), not an opaque location string. Resolves the path/uri debate: name stays `path`, semantics become URI. - checksum form changes from <algorithm>:base64(<digest>) to <algorithm>:<digest> with per-algorithm encoding (lowercase hex for MD5/CRC32/CRC32C/SHA-256, opaque for ETAG); add RFC references and an Encoding column. - content_type: MIME per RFC 2046, defaults to application/octet-stream when unset. - offset must not be negative. - Note that implementations are not expected to treat empty strings as null. Co-authored-by: Isaac
|
@brkyvz can you reply on the path thread? |
@rok sorry that was hidden in the UI. Responded! We weren't planning on renaming the field. Just explaining that it is a URI |
…@ 92228a1) Align with the latest apache/parquet-format#585 (commit 92228a1): - Update checksum RFC citations: MD5 -> RFC 1321, CRC32 -> RFC 2083, CRC32C -> RFC 3385 (SHA-256 unchanged at RFC 6234). - Readers may return a null file value for a row whose reference is invalid. Co-authored-by: Isaac
See my reply in the thread above. I don't think "we weren't planning" sufficiently answers this. |
…o#585 @ 4223744) Align with apache/parquet-format#585 (commit 4223744): the FILE locator field was renamed from `path` to `uri`. Rename the field throughout the field table, resolution table, Parquet examples, writer/reader requirements, statistics, and prose. Generic uses of "path" (field path, absolute path) are unchanged, as is the DBR-specific __FILE_TYPE_MODE storage-mode key. Co-authored-by: Isaac
| * MAP - undefined | ||
| * VARIANT - undefined | ||
| * GEOMETRY - undefined | ||
| * GEOGRAPHY - undefined |
There was a problem hiding this comment.
| * GEOGRAPHY - undefined | |
| * FILE - undefined | |
| can be renamed or relocated as a single unit. | ||
|
|
There was a problem hiding this comment.
| can be renamed or relocated as a single unit. | |
| can be renamed or relocated as a single unit. | |
| Parquet files containing self-references must not use Parquet modular encryption. | |
| Self-referenced byte ranges are not Parquet encryption modules and therefore cannot | |
| be encrypted or authenticated independently. Encryption of external files referenced | |
| by `uri` is outside the scope of the Parquet format. | |
Rationale for this change
Introduces a new type called File as a typed FileReference. The design document is here.
The motivation is as follows:
What changes are included in this PR?
Introduces the specification for FileType.
Do these changes have PoC implementations?
Yes: