Skip to content

[SPARK-27267][CORE] Update snappy to avoid error when decompressing empty serialized data - #24242

Closed
srowen wants to merge 1 commit into
apache:masterfrom
srowen:SPARK-27267
Closed

[SPARK-27267][CORE] Update snappy to avoid error when decompressing empty serialized data#24242
srowen wants to merge 1 commit into
apache:masterfrom
srowen:SPARK-27267

Conversation

@srowen

@srowen srowen commented Mar 29, 2019

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

(See JIRA for problem statement)

Update snappy 1.1.7.1 -> 1.1.7.3 to pick up an empty-stream and Java 9 fix.

There appear to be no other changes of consequence:
https://github.com/xerial/snappy-java/blob/master/Milestone.md

How was this patch tested?

Existing tests

@SparkQA

SparkQA commented Mar 29, 2019

Copy link
Copy Markdown

Test build #104089 has finished for PR 24242 at commit ba33cb1.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

kiszk commented Mar 30, 2019

Copy link
Copy Markdown
Member

LGTM, pending Jenkins

@SparkQA

SparkQA commented Mar 30, 2019

Copy link
Copy Markdown

Test build #4668 has finished for PR 24242 at commit ba33cb1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen added a commit that referenced this pull request Mar 30, 2019
…mpty serialized data

(See JIRA for problem statement)

Update snappy 1.1.7.1 -> 1.1.7.3 to pick up an empty-stream and Java 9 fix.

There appear to be no other changes of consequence:
https://github.com/xerial/snappy-java/blob/master/Milestone.md

Existing tests

Closes #24242 from srowen/SPARK-27267.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
(cherry picked from commit 2ec650d)
Signed-off-by: Sean Owen <sean.owen@databricks.com>
@srowen

srowen commented Mar 30, 2019

Copy link
Copy Markdown
Member Author

Merged to master/2.4

@srowen srowen closed this in 2ec650d Mar 30, 2019
@dongjoon-hyun

Copy link
Copy Markdown
Member

Hi, All.
It seems that we missed hadoop-2.6 profile in branch-2.4.
Please review the followup PR, #24254 .

@srowen

srowen commented Mar 30, 2019

Copy link
Copy Markdown
Member Author

Arg. Sorry I always forget that. Thanks @dongjoon-hyun

@srowen
srowen deleted the SPARK-27267 branch March 31, 2019 01:25
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
…mpty serialized data

(See JIRA for problem statement)

Update snappy 1.1.7.1 -> 1.1.7.3 to pick up an empty-stream and Java 9 fix.

There appear to be no other changes of consequence:
https://github.com/xerial/snappy-java/blob/master/Milestone.md

Existing tests

Closes apache#24242 from srowen/SPARK-27267.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
(cherry picked from commit 2ec650d)
Signed-off-by: Sean Owen <sean.owen@databricks.com>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 25, 2019
…mpty serialized data

(See JIRA for problem statement)

Update snappy 1.1.7.1 -> 1.1.7.3 to pick up an empty-stream and Java 9 fix.

There appear to be no other changes of consequence:
https://github.com/xerial/snappy-java/blob/master/Milestone.md

Existing tests

Closes apache#24242 from srowen/SPARK-27267.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
(cherry picked from commit 2ec650d)
Signed-off-by: Sean Owen <sean.owen@databricks.com>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
…mpty serialized data

(See JIRA for problem statement)

Update snappy 1.1.7.1 -> 1.1.7.3 to pick up an empty-stream and Java 9 fix.

There appear to be no other changes of consequence:
https://github.com/xerial/snappy-java/blob/master/Milestone.md

Existing tests

Closes apache#24242 from srowen/SPARK-27267.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
(cherry picked from commit 2ec650d)
Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants