[SPARK-11504][SQL] API audit for distributeBy and localSort - #9470
Closed
rxin wants to merge 2 commits into
Closed
Conversation
rxin
commented
Nov 4, 2015
Contributor
- Renamed localSort -> sortWithinPartitions to avoid ambiguity in "local"
- distributeBy -> repartition to match the existing repartition.
Contributor
Author
Contributor
|
LGTM pending jenkins. |
Contributor
|
test this please |
|
Test build #45030 has finished for PR 9470 at commit
|
Contributor
|
Merging to master. |
|
Test build #45031 has finished for PR 9470 at commit
|
markhamstra
pushed a commit
to markhamstra/spark
that referenced
this pull request
Nov 11, 2015
1. Renamed localSort -> sortWithinPartitions to avoid ambiguity in "local" 2. distributeBy -> repartition to match the existing repartition. Author: Reynold Xin <rxin@databricks.com> Closes apache#9470 from rxin/SPARK-11504.
Contributor
There was a problem hiding this comment.
@rxin This causes an infinite loop, which isn't caught by the unit tests since DataFrameSuite only tests the Column* overload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.