Add Python native operator dependencies - #2167
Merged
Merged
Conversation
kunwp1
requested changes
Sep 27, 2023
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
Following up on apache#2157, this PR adds a dependency file `operator-requirements.txt`, which declares the dependencies used in native Python operators.
mengw15
pushed a commit
to mengw15/texeraFork
that referenced
this pull request
Jul 5, 2026
### What changes were proposed in this PR? Removes three Python packages that nothing uses and moves `ruff` to the dev-only requirements file: | Package | File | Why it can go | | --- | --- | --- | | `Deprecated==1.2.14` | requirements.txt | Last import removed in apache#2847; no installed package requires it | | `protobuf==7.34.1` | requirements.txt | No `google.protobuf` import anywhere; betterproto 2.0 runtime does not depend on it (only its optional extras do) | | `pybase64==1.3.2` | operator-requirements.txt | Added in apache#2167, but the operator templates have always used the stdlib `base64` (see `ImageUtility.scala` in that PR) — zero references to `pybase64` in the entire git history | | `ruff==0.14.7` | requirements.txt → dev-requirements.txt | Lint tool, not a runtime dependency; keeping it in requirements.txt wrongly puts it in LICENSE-binary-python | Follow-up changes required by the move/removals: - `.github/workflows/build.yml`: the "Lint with Ruff" step now runs after "Install dev dependencies", since ruff comes from dev-requirements.txt. - `amber/LICENSE-binary-python`: dropped the four matching entries. `wrapt` stays — it is still a hard dependency of `aiobotocore`, not just of `Deprecated`. - Added `# Not imported directly: ...` comments to the transitive pins (`setuptools`, `python-dateutil`, `s3fs`/`aiobotocore`, `SQLAlchemy`/`pg8000`, `scikit-image`) so they don't look unused in future audits. ### Any related issues, documentation, discussions? Closes apache#6101 ### How was this PR tested? Uninstalled the three packages from the local venv (`pip uninstall -y protobuf Deprecated pybase64`), then ran the existing test suite and the same lint commands CI runs: ``` cd amber && pytest -m "not integration" -q # 551 passed, 1 deselected in 64s cd amber && ruff check src/main/python src/test/python && ruff format --check src/main/python src/test/python # All checks passed! 190 files already formatted ``` No new tests: dependency-manifest-only change; CI's `check_binary_deps.py` license gate verifies the LICENSE-binary-python entries match the installed set. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-fable-5) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #2157, this PR adds a dependency file
operator-requirements.txt, which declares the dependencies used in native Python operators.