Skip to content

Add workflow-operator to micro-services - #2994

Merged
bobbai00 merged 15 commits into
masterfrom
jiadong-add-operators
Nov 5, 2024
Merged

Add workflow-operator to micro-services#2994
bobbai00 merged 15 commits into
masterfrom
jiadong-add-operators

Conversation

@bobbai00

@bobbai00 bobbai00 commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

This PR adds the workflow-operator to the micro-services.

Dependencies of this component

workflow-operator depends on workflow-core for definitions related to operator executer, sink storage and file resolver.

How the move is done

Two packages are added:

  • com.kjetland.jackson.jsonSchema, directly copy from core/amber/src/main/scala/com/kjetland/jackson/jsonSchema
  • edu.uci.ics.amber.operator, it contains the following codes:
    • all operators core/amber/src/main/scala/edu/uci/ics/texera/workflow/operators
    • filter, flatmap, map, source under core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/operators
    • amber.operator.metadata package: include metadata under core/amber/src/main/scala/edu/uci/ics/texera/workflow/common, files like scanner and some constants under this directory have been merged to the usages.

Few issues

CSVScanSourceOpExec implements the CheckpointSupport, which requires the dependencies of akka. So The implementation is currently dropped in micro-services/workflow-operator

Future PR plan

Once this PR get merged, micro-services/workflow-compiling-service will be added, and then core/amber will be moved to micro-services/.

@bobbai00
bobbai00 requested a review from Yicong-Huang November 4, 2024 15:47
@bobbai00 bobbai00 self-assigned this Nov 4, 2024

@Yicong-Huang Yicong-Huang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good. Left some comments for changes.

Comment thread core/micro-services/workflow-operator/build.sbt
Comment thread core/micro-services/workflow-operator/build.sbt Outdated
@bobbai00
bobbai00 requested a review from Yicong-Huang November 4, 2024 18:22
Comment thread core/micro-services/workflow-operator/build.sbt

@Yicong-Huang Yicong-Huang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobbai00
bobbai00 merged commit 9462518 into master Nov 5, 2024
@bobbai00
bobbai00 deleted the jiadong-add-operators branch November 5, 2024 15:41
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
This PR adds the `workflow-operator` to the `micro-services`.

### Dependencies of this component
`workflow-operator` depends on `workflow-core` for definitions related
to operator executer, sink storage and file resolver.

### How the move is done

Two packages are added:
- `com.kjetland.jackson.jsonSchema`, directly copy from
`core/amber/src/main/scala/com/kjetland/jackson/jsonSchema`
- `edu.uci.ics.amber.operator`, it contains the following codes:
- all operators
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/operators`
- `filter`, `flatmap`, `map`, `source` under
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/operators`
- `amber.operator.metadata` package: include `metadata` under
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/common`, files
like `scanner` and some constants under this directory have been merged
to the usages.
   
### Few issues

`CSVScanSourceOpExec` implements the `CheckpointSupport`, which requires
the dependencies of akka. So The implementation is currently dropped in
`micro-services/workflow-operator`


### Future PR plan

Once this PR get merged, `micro-services/workflow-compiling-service`
will be added, and then `core/amber` will be moved to `micro-services/`.

---------

Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
SarahAsad23 pushed a commit to madisonmlin/texera that referenced this pull request May 20, 2026
This PR adds the `workflow-operator` to the `micro-services`.

### Dependencies of this component
`workflow-operator` depends on `workflow-core` for definitions related
to operator executer, sink storage and file resolver.

### How the move is done

Two packages are added:
- `com.kjetland.jackson.jsonSchema`, directly copy from
`core/amber/src/main/scala/com/kjetland/jackson/jsonSchema`
- `edu.uci.ics.amber.operator`, it contains the following codes:
- all operators
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/operators`
- `filter`, `flatmap`, `map`, `source` under
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/operators`
- `amber.operator.metadata` package: include `metadata` under
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/common`, files
like `scanner` and some constants under this directory have been merged
to the usages.
   
### Few issues

`CSVScanSourceOpExec` implements the `CheckpointSupport`, which requires
the dependencies of akka. So The implementation is currently dropped in
`micro-services/workflow-operator`


### Future PR plan

Once this PR get merged, `micro-services/workflow-compiling-service`
will be added, and then `core/amber` will be moved to `micro-services/`.

---------

Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
yangzhang75 pushed a commit to yangzhang75/texera that referenced this pull request Jun 22, 2026
This PR adds the `workflow-operator` to the `micro-services`.

### Dependencies of this component
`workflow-operator` depends on `workflow-core` for definitions related
to operator executer, sink storage and file resolver.

### How the move is done

Two packages are added:
- `com.kjetland.jackson.jsonSchema`, directly copy from
`core/amber/src/main/scala/com/kjetland/jackson/jsonSchema`
- `edu.uci.ics.amber.operator`, it contains the following codes:
- all operators
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/operators`
- `filter`, `flatmap`, `map`, `source` under
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/operators`
- `amber.operator.metadata` package: include `metadata` under
`core/amber/src/main/scala/edu/uci/ics/texera/workflow/common`, files
like `scanner` and some constants under this directory have been merged
to the usages.
   
### Few issues

`CSVScanSourceOpExec` implements the `CheckpointSupport`, which requires
the dependencies of akka. So The implementation is currently dropped in
`micro-services/workflow-operator`


### Future PR plan

Once this PR get merged, `micro-services/workflow-compiling-service`
will be added, and then `core/amber` will be moved to `micro-services/`.

---------

Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants