fix(ci): rename backport auto-label output so its report step runs - #7022
Merged
Yicong-Huang merged 2 commits intoJul 29, 2026
Merged
Conversation
The `Report backport decisions` step is skipped on every run because its
guard reads `steps.label.outputs.result`. actions/github-script always
writes the script's return value to an output named `result` after the
body runs; the Label step returns nothing, so that write blanks out the
explicit `core.setOutput("result", …)` and the guard is always false.
Rename the output to `decisions` (github-script only reserves `result`)
so the report comment and release-manager review request from apache#6962
actually fire.
Closes apache#7021
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7022 +/- ##
============================================
- Coverage 83.26% 79.19% -4.07%
- Complexity 225 3785 +3560
============================================
Files 533 1160 +627
Lines 30097 46118 +16021
Branches 3222 5114 +1892
============================================
+ Hits 25059 36525 +11466
- Misses 4233 7972 +3739
- Partials 805 1621 +816
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 355 | 0.217 | 27,233/40,392/40,392 us | 🔴 -6.9% / 🔴 +156.1% |
| 🔴 | bs=100 sw=10 sl=64 | 773 | 0.472 | 128,479/147,871/147,871 us | 🔴 +7.7% / 🔴 +37.7% |
| ⚪ | bs=1000 sw=10 sl=64 | 899 | 0.549 | 1,118,302/1,141,541/1,141,541 us | ⚪ within ±5% / 🔴 +14.1% |
Baseline details
Latest main f319f04 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 355 tuples/sec | 381 tuples/sec | 786.12 tuples/sec | -6.8% | -54.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.217 MB/s | 0.233 MB/s | 0.48 MB/s | -6.9% | -54.8% |
| bs=10 sw=10 sl=64 | p50 | 27,233 us | 26,420 us | 12,305 us | +3.1% | +121.3% |
| bs=10 sw=10 sl=64 | p95 | 40,392 us | 40,240 us | 15,774 us | +0.4% | +156.1% |
| bs=10 sw=10 sl=64 | p99 | 40,392 us | 40,240 us | 18,978 us | +0.4% | +112.8% |
| bs=100 sw=10 sl=64 | throughput | 773 tuples/sec | 805 tuples/sec | 999.71 tuples/sec | -4.0% | -22.7% |
| bs=100 sw=10 sl=64 | MB/s | 0.472 MB/s | 0.492 MB/s | 0.61 MB/s | -4.1% | -22.6% |
| bs=100 sw=10 sl=64 | p50 | 128,479 us | 119,275 us | 100,616 us | +7.7% | +27.7% |
| bs=100 sw=10 sl=64 | p95 | 147,871 us | 159,297 us | 107,356 us | -7.2% | +37.7% |
| bs=100 sw=10 sl=64 | p99 | 147,871 us | 159,297 us | 113,255 us | -7.2% | +30.6% |
| bs=1000 sw=10 sl=64 | throughput | 899 tuples/sec | 901 tuples/sec | 1,031 tuples/sec | -0.2% | -12.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.549 MB/s | 0.55 MB/s | 0.63 MB/s | -0.2% | -12.8% |
| bs=1000 sw=10 sl=64 | p50 | 1,118,302 us | 1,115,693 us | 980,328 us | +0.2% | +14.1% |
| bs=1000 sw=10 sl=64 | p95 | 1,141,541 us | 1,137,231 us | 1,027,528 us | +0.4% | +11.1% |
| bs=1000 sw=10 sl=64 | p99 | 1,141,541 us | 1,137,231 us | 1,054,298 us | +0.4% | +8.3% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,563.35,200,128000,355,0.217,27233.03,40391.88,40391.88
1,100,10,64,20,2587.37,2000,1280000,773,0.472,128478.97,147871.16,147871.16
2,1000,10,64,20,22236.99,20000,12800000,899,0.549,1118302.28,1141540.86,1141540.86
aglinxinyuan
approved these changes
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The
Report backport decisionsstep inbackport-auto-label.ymlis skipped on every run, so the report comment and release-manager review request added in #6962 never fire.Root cause: the step's guard reads
steps.label.outputs.result.actions/github-scriptalways writes the script's return value to an output namedresultafter the body runs. TheLabel fix PRsscript has noreturn, so that post-run write blanks out the explicitcore.setOutput("result", …)— the guard is therefore always false.Fix: rename the output to
decisions(github-script only reservesresult), and update the guard and theRESULTenv reference to match. No logic in either step changes.Any related issues, documentation, discussions?
Closes #7021.
How was this PR tested?
30423275226(PR fix(workflow-operator): re-validate redirect hops in HF remote-URL fetches to close an SSRF bypass #7013): theReport backport decisionsstep showsskipped.<!-- backport-auto-label-report -->comments across fix(workflow-operator): re-validate redirect hops in HF remote-URL fetches to close an SSRF bypass #7013, fix(docs): use a plain year range in NOTICE copyright #6983, fix: Add missing license headers to Docs #6958, fix(deps, frontend): update dependency ajv to v8.18.0 [security] #6908 (including PRs that were auto-labeled), confirming the step is systemically skipped.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)