ADFA-4202: Guard tooling-api shadow jar against public-suffix-list regression

[davidschachterADFA]

Summary

• ADFA-4202 (drop the unused mozilla/public-suffix-list.txt httpclient resource from the APK) was already fixed under ADFA-4551 via app/build.gradle.kts's packaging.resources.excludes.
• That exclude only governs the top-level APK resource merge — it can't reach bytes already baked into tooling-api-impl's shadow/fat jar (tooling-api-all.jar), which is copied in as a raw asset.
• Adds a matching exclude(...) to the shadowJar task so a future dependency shift (e.g. sdklib pulling httpclient in differently) can't reintroduce the file through that path.

Test plan

• ./gradlew :subprojects:tooling-api-impl:jar builds successfully
• unzip -l tooling-api-all.jar confirms mozilla/public-suffix-list.txt is absent
• ./gradlew spotlessCheck passes

🤖 Generated with Claude Code

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 83396a8a-47bb-454a-bb61-39e250e9d3cd

📥 Commits

Reviewing files that changed from the base of the PR and between 2e606b7 and b1db1ad.

📒 Files selected for processing (1)

• subprojects/tooling-api-impl/build.gradle.kts

---

📝 Walkthrough

• Excludes the unused mozilla/public-suffix-list.txt resource from the tooling-api-all.jar shadow JAR.
• Prevents the resource from being reintroduced through future dependency changes.
• Validation completed with a successful Gradle build, archive inspection, and spotlessCheck.
• No notable risks or best-practice violations identified.

Walkthrough

The tooling API’s shadowJar task now excludes the transitive mozilla/public-suffix-list.txt resource and documents the packaging-level exclusion.

Changes

Tooling packaging

Layer / File(s)	Summary
Exclude public-suffix resource subprojects/tooling-api-impl/build.gradle.kts	Configures shadowJar to omit mozilla/public-suffix-list.txt from the shaded artifact and documents its transitive origin.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• appdevforall/CodeOnTheGo#1571: Adjusts Android resource packaging to exclude the same public-suffix resource.
• appdevforall/CodeOnTheGo#1593: Adjusts Gradle packaging/shading excludes for the same resource.

Poem

A rabbit hops through shaded jars,
“No suffix list among the stars!”
One transitive file now stays away,
From every bundled byte today.
“Clean packaging!” we cheer and play.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding a shadowJar guard for the public-suffix-list regression.
Description check	✅ Passed	The description is directly about the shadowJar exclusion change and its validation steps.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ADFA-4202-remove-public-suffix-list

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}