Skip to content

Fix usage stats disabled home view#896

Merged
eldadfux merged 1 commit into
appwrite:0.7.xfrom
lohanidamodar:fix-usage-stats-disabled-home-view
Feb 10, 2021
Merged

Fix usage stats disabled home view#896
eldadfux merged 1 commit into
appwrite:0.7.xfrom
lohanidamodar:fix-usage-stats-disabled-home-view

Conversation

@lohanidamodar

Copy link
Copy Markdown
Member

What does this PR do?

Before this fix when stats disabled
before

After
after

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@eldadfux
eldadfux changed the base branch from master to 0.7.x February 10, 2021 12:06
@eldadfux
eldadfux merged commit 9489834 into appwrite:0.7.x Feb 10, 2021
abnegate added a commit that referenced this pull request Jun 18, 2026
…le PDOProxy

The Swoole PDOProxy keeps its own transaction counter that desyncs on a
mid-transaction connection loss and is never reset on reconnect or pool checkin,
poisoning pooled connections (every later startTransaction trusts the stale
counter and fails with "There is no active transaction" until restart).

utopia-php/database#896 moves connection-loss recovery into the adapter
(reconnect-on-execute via Utopia\Database\PDOStatement + withTransaction replay)
with the real PDO as the single source of truth, so the proxy is no longer
needed and the desync is structurally impossible.

- registers.php: wrap connections in Utopia\Database\PDO directly instead of
  Swoole\Database\PDOProxy.
- Set PDO::ATTR_ERRMODE => ERRMODE_EXCEPTION explicitly (previously enforced by
  the proxy; also defaulted by #896, set here for clarity).
- Require the #896 branch via a VCS repository until it is tagged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
abnegate added a commit that referenced this pull request Jun 18, 2026
…le PDOProxy

The Swoole PDOProxy keeps its own transaction counter that desyncs on a
mid-transaction connection loss and is never reset on reconnect or pool checkin,
poisoning pooled connections (every later startTransaction trusts the stale
counter and fails with "There is no active transaction" until restart).

utopia-php/database#896 moves connection-loss recovery into the adapter
(reconnect-on-execute via Utopia\Database\PDOStatement + withTransaction replay)
with the real PDO as the single source of truth, so the proxy is no longer
needed and the desync is structurally impossible.

- registers.php: wrap connections in Utopia\Database\PDO directly instead of
  Swoole\Database\PDOProxy.
- Set PDO::ATTR_ERRMODE => ERRMODE_EXCEPTION explicitly (previously enforced by
  the proxy; also defaulted by #896, set here for clarity).
- Require the #896 branch via a VCS repository until it is tagged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
abnegate added a commit that referenced this pull request Jun 18, 2026
…le PDOProxy

The Swoole PDOProxy keeps its own transaction counter that desyncs on a
mid-transaction connection loss and is never reset on reconnect or pool checkin,
poisoning pooled connections (every later startTransaction trusts the stale
counter and fails with "There is no active transaction" until restart).

utopia-php/database#896 moves connection-loss recovery into the adapter
(reconnect-on-execute via Utopia\Database\PDOStatement + withTransaction replay)
with the real PDO as the single source of truth, so the proxy is no longer
needed and the desync is structurally impossible.

- registers.php: wrap connections in Utopia\Database\PDO directly instead of
  Swoole\Database\PDOProxy.
- Set PDO::ATTR_ERRMODE => ERRMODE_EXCEPTION explicitly (previously enforced by
  the proxy; also defaulted by #896, set here for clarity).
- Require the #896 branch via a VCS repository until it is tagged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
abnegate added a commit that referenced this pull request Jun 18, 2026
…le PDOProxy

The Swoole PDOProxy keeps its own transaction counter that desyncs on a
mid-transaction connection loss and is never reset on reconnect or pool checkin,
poisoning pooled connections (every later startTransaction trusts the stale
counter and fails with "There is no active transaction" until restart).

utopia-php/database#896 moves connection-loss recovery into the adapter
(reconnect-on-execute via Utopia\Database\PDOStatement + withTransaction replay)
with the real PDO as the single source of truth, so the proxy is no longer
needed and the desync is structurally impossible.

- registers.php: wrap connections in Utopia\Database\PDO directly instead of
  Swoole\Database\PDOProxy.
- Set PDO::ATTR_ERRMODE => ERRMODE_EXCEPTION explicitly (previously enforced by
  the proxy; also defaulted by #896, set here for clarity).
- Require the #896 branch via a VCS repository until it is tagged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants