Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Fix for Windows#4

Merged
eldadfux merged 1 commit into
appwrite:masterfrom
tminich:win_fix
Dec 2, 2019
Merged

Fix for Windows#4
eldadfux merged 1 commit into
appwrite:masterfrom
tminich:win_fix

Conversation

@tminich

@tminich tminich commented Dec 2, 2019

Copy link
Copy Markdown
Contributor

On Windows the path includes the drive (e.g. 'C:\temp\to_scan.file') so the original fails as stats contains the path, not 'OK'.

@eldadfux

eldadfux commented Dec 2, 2019

Copy link
Copy Markdown
Member

Hey @tminich, can you please paste the entire output you get on Windows, so Ill be able to make sure other platforms will work OK after this merge.

@tminich

tminich commented Dec 2, 2019

Copy link
Copy Markdown
Contributor Author

If I keep the original [$file, $stats] = explode(':', $out); and scan 'C:\xampp\htdocs\test\test.php' and dump $file and $stats I get:

string(1) "C"
string(27) "\xampp\htdocs\test\test.php"

@eldadfux

eldadfux commented Dec 2, 2019

Copy link
Copy Markdown
Member

Are you using this library with a local ClamAV setup or our docker image?

@tminich

tminich commented Dec 2, 2019

Copy link
Copy Markdown
Contributor Author

Local ClamAV setup for testing.

@eldadfux
eldadfux merged commit 7f11971 into appwrite:master Dec 2, 2019
@eldadfux

eldadfux commented Dec 2, 2019

Copy link
Copy Markdown
Member

Thanks for the PR! if you like me to send you some cool Appwrite swags, contact me on our Discord server:
https://discord.gg/GSeTUeA

@tminich

tminich commented Dec 2, 2019

Copy link
Copy Markdown
Contributor Author

No problem, was just an easy quick fix =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants