Update Flutter SDK to add offline support - #618
Conversation
00e5b11 to
6358c99
Compare
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Looks good. Let's make sure the generated SDK looks good as well once we have changes to the API and swagger spec with updated requirement. We must update the mock endpoints to support these new functionalities as well.
02fb129 to
9e7e0c4
Compare
@lohanidamodar, what were you thinking we would do for the mock endpoints? |
Can we have mock endpoints with cache labels, and may be run test and check if data is cached? |
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Looks good. Left few comments. Let's also see the generated SDK with new Spec and this branch 🙏🏻
| 'offline' => [ | ||
| 'model' => $method['x-appwrite']['offline-model'] ?? '', | ||
| 'key' => $method['x-appwrite']['offline-key'] ?? '', | ||
| 'model' => $method['x-appwrite']['offline-model'] ?? '', |
There was a problem hiding this comment.
| 'model' => $method['x-appwrite']['offline-model'] ?? '', |
Looks like this was defined twice
|
|
||
| // ID helper tests | ||
| print(ID.unique()); | ||
| // print(ID.unique()); |
There was a problem hiding this comment.
we can remove this or we can test this by printing twice making sure it gives back unique ID each time?
|
|
||
| // ID helper tests | ||
| print(ID.unique()); | ||
| // print(ID.unique()); |
603ae18 to
b37f539
Compare
|
@lohanidamodar, I've updated the PR based on your feedback including adding the mock labels: appwrite/appwrite#5160 |
3a1a9e2 to
50950e3
Compare
50950e3 to
d651cec
Compare
abnegate
left a comment
abnegate
left a comment
There was a problem hiding this comment.
Looks good, just some hard-coded Appwrite references to template 👍
d651cec to
3aa4cf3
Compare
3 participants
What does this PR do?
Update the Flutter SDK to add Offline Support.
Test Plan
Manual
Related PRs and Issues
TODO
Have you read the Contributing Guidelines on issues?
Yes