Skip to content

fix: correct typos in error messages and guard empty coordinate extraction #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fix2015 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix: correct typos in error messages and guard empty coordinate extraction #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/askui/models/anthropic/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,8 @@
def extract_click_coordinates(text: str) -> tuple[int, int]:
pattern = r"<click>(\d+),\s*(\d+)"
matches = re.findall(pattern, text)
if not matches:
msg = f"No click coordinates found in text: {text}"
raise ValueError(msg)
x, y = matches[-1]
return int(x), int(y)
4 changes: 2 additions & 2 deletions src/askui/tools/android/ppadb_agent_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def _get_selected_device(self) -> AndroidDevice:
devices: list[AndroidDevice] = self._get_connected_devices()

if not self._device:
msg = "No device is selected, did you call on of the set_device methods?"
msg = "No device is selected, did you call one of the set_device methods?"
raise AndroidAgentOsError(msg)

for device in devices:
Expand All @@ -447,7 +447,7 @@ def _get_selected_device(self) -> AndroidDevice:

def _check_if_display_is_selected(self) -> None:
if self._selected_display is None:
msg = "No display is selected, did you call on of the set_display methods?"
msg = "No display is selected, did you call one of the set_display methods?"
raise AndroidAgentOsError(msg)

def _get_connected_devices(self) -> list[AndroidDevice]:
Expand Down