v0.24.0-1 QA Review

[smashwilson]

Changes to verify

• Suppress "Unable to locate git workspace root" error #1809: Suppress "Unable to locate git workspace root" error
• Add button to show/hide password in credentials dialog #1808: Add button to show/hide password in credentials dialog
• Fix bug where pull request cannot be viewed if pullRequest.headRepository is null. #1828: Fix bug where pull request cannot be viewed if pullRequest.headRepository is null
• Fix: git tab keeps popping open when there's a merge conflict #1822: Fix: git tab keeps popping open when there's a merge conflict
• View commit details in pane #1807: View commit details in pane
• Backportable keymap changes #1847: Backportable keymap changes
• Add tab for all changed files in a pull request #1829: Add tab for all changed files in a pull request
• Fix: handle renames on file changed tab #1854: Handle renames on files changed tab
• Adjustable diff font size #1859: Adjustable diff font size
• Fix: wrong prefix on PR files changed #1855: Fix: wrong prefix on PR files changed
• Commit Preview tweaks #1805: Commit preview tweaks
• UserStore handles GitHub remotes that no longer exist #1869: UserStore handles GitHub remotes that no longer exist
• Clean CI check on Upgrade GitHub package on dev atom#18641

Other changes in this release

• Update screenshots #1810: Update screenshots
• Process iteration #1811: Process iteration
• split IssueishDetailView into IssueDetailView and PullRequestDetailView #1804: Split IssueishDetailView into IssueDetailView and PullRequestDetailView
• Moving to CodeCov #1826: Moving to CodeCov
• Disable the "changes" status from CodeCov #1827: Disable the "changes" status from CodeCov
• Move the multi-file diff RFC to "feature requests" with the others #1831: Move the multi-file diff RFC to "feature requests" with the others
• Enzyme and Enzyme adapter upgrade #1836: Enzyme and Enzyme adapter upgrade
• Update event-kit to the latest version 🚀 #1799: Update event-kit to the latest version
• Update tree-kill to the latest version 🚀 #1777: Update tree-kill to the latest version
• No need for AppVeyor reporter #1837: No need for AppVeyor reporter
• Update relay-compiler to the latest version 🚀 #1772: Update relay-compiler to the latest version
• Build PRs that only change documentation #1843: Build PRs that only change documentation
• Bring our GraphQL schema up to date #1838: Bring our GraphQL schema up to date
• Pin codecov package to the lastest master #1845: Pin CodeCov package to the latest master
• fix: react-component-atlas #1842: Fix React component atlas
• Update temp to the latest version 🚀 #1846: Update temp to the latest version
• Remove status section from feature proposal template #1849: Remove status section from feature proposal template
• Update what-the-diff to the latest version 🚀 #1851: Update what-the-diff to the latest version

[smashwilson]

Holding the release until we can fix #1868.

[robertrossmann]

Not sure if this is the right place to report QA-related feedback, but here are some some issues and general suggestions. Let me know if you'd like me to split these into separate issues. 😇

Pull request tabs' titles have selectable text

Breaks the feeling of them being buttons.

---

Spacing before Show more on a commit message

While looking at pull request details => commits, the Show more button is too close to the commit message.

---

Opening very large diffs from the "Recent commits" actually opens the very large diff

I think there used to be that Diff too large warning when I click on a file with staged changes with too many lines - not sure if that's been removed or if this is a regression, but for diffs with tens of thousands of changed lines Atom still becomes very unresponsive while rendering the diff.

Steps to reproduce:

1. Clone the tree-sitter-javascript project and open this commit in Atom: tree-sitter/tree-sitter-javascript@1996b31
2. Observe Atom hanging for several minutes while rendering the diff

Expected behaviour:

Github detects a large diff and skips rendering the diff for large files or warns before opening the diff pane

---

UI/UX suggestions

Show committer's name in commit details pane

I usually recognise my co-workers/fellow open-sourcerers by their names, or by their Github handles. I would prefer to see at least the committer's name in the commit details pane.

Stretch goal: show a card on hover with additional information fetched from Github (inspiration)

---

Add a Copy commit shasum button wherever a shasum is shown in commit details panes

Being able to copy the commit shasum would be great for continuing my work in other tools (ie. the git CLI). This could be especially useful on the pull request details pane.

Alternatively, show the full commit shasum as text somewhere so the user can copy it manually.

---

Hopefully you'll find this feedback useful. Nice work! ❤️

[smashwilson]

@robertrossmann Oh wow, thanks! This is super thorough and helpful.

Not sure if this is the right place to report QA-related feedback [..]

You're right, I think we'd prefer to track these as separate issues rather than grouping them all here. You've already taken the trouble to write it all up, though, so I can handle the splitting 😄

These QA issues are part of the way we ship - they're intended to be a final, simple smoke test to ensure that all of the bugs and features we think we're releasing still actually work once we tag a release and include it in a full Atom build as a bundled module distributed within Atom's startup snapshot. Historically, we've had a few pretty bad problems that almost made it to release because they were hidden by our usual testing M.O. of installing the package non-bundled from git, and linking it in dev mode. With that in mind, I'll hold up 0.24.0 tag for the graphical glitches you've found, but the others we'll keep as issues for a future sprint to keep our release scope from creeping.

[robertrossmann]

Thank you @smashwilson for the explanation - in the future, I'll open up separate issues for all of these. ❤️

[smashwilson]

Okay, I think I got them all; the "large diff" gate issue was already captured here: #1759.

Thank you @smashwilson for the explanation - in the future, I'll open up separate issues for all of these. ❤️

✨ 👍

[smashwilson]

Next release candidate QA checklist: #1879