Display loading indicator while FilePatchView is loading

[kuychaco]

... so that the UI feels more responsive when displaying large diffs

[smashwilson]

I'll have a look at this next week! 😄

[BinaryMuse]

I started working on this yesterday, but since the slow rendering is synchronous, it doesn't seem to help much. I tried a strategy to show the first couple hundred lines and then render the rest and it feels even slower. I'm not sure this is a good idea in hindsight

[smashwilson]

Ah so it's actually the rendering speed that's the bottleneck, rather than computing and fetching and parsing the patch? Yeah, that feels like something that would be a lot easier to tackle once Fiber lands.

[smashwilson]

(Assuming that my intuition about what Fiber does is correct, that is.)

[BinaryMuse]

Yeah, is the synchronous DOM flushing from etch and the associated layout recalculation from showing the tab. Using a tiling strategy is the right thing but since we're moving to use the editor, which already does this, I don't think we should put forth the effort.