docs(batch): snippet typo in custom batch processor#961
Merged
Conversation
Under "Creating a custom batch processor" example the ddb_table in not defined. Instead consider `self.ddb_table`
boring-cyborg
Bot
added
the
documentation
pull-request-size
Bot
added
the
size/XS
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
heitorlessa
approved these changes
Jan 17, 2022
heitorlessa
left a comment
heitorlessa
left a comment
Contributor
There was a problem hiding this comment.
Thank you so so much for this fix @thehananbhat
heitorlessa
changed the title
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
heitorlessa
added a commit
that referenced
this pull request
Jan 20, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(batch): report multiple failures (#967) docs(tutorial): fix path to images (#963) Update documentation mistake (#961)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Variable
ddb_tableis not defined in the class. Updated with instance variableself.ddb_tableChecklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/utilities/batch.md