fix: version and type are required by the message format - #217
Merged
Conversation
resolves aws#209 The version and type are required values. This error will help clarify malformed messages. Especially string messages that have been encoded and the proper encoding has not been passed.
seebees
force-pushed
the
verify_version_and_type
branch
from
September 18, 2019 16:57
8a91c04 to
5d14443
Compare
If the blob looks like it was base64 encoded, note this in the error message.
This was referenced Sep 19, 2019
mattsb42-aws
previously approved these changes
Sep 20, 2019
mattsb42-aws
approved these changes
Sep 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #209
The version and type are required values.
This error will help clarify malformed messages.
Especially string messages that have been encoded
and the proper encoding has not been passed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: