Exempt URL columns from width cap in generic table renderer

[jeremy]

Summary

• selectColumns() capped all column widths at 40 for column-dropping math, but formatCell() never truncates URLs — the mismatch caused URL-bearing columns to overflow the terminal and garble with line wraps
• Track a containsURL flag on the column struct during the existing width loop (same formatTableCell render path), skip the 40-char cap for flagged columns
• Affected production fields: href, app_href, *_url — any column whose values pass isURL()

Test plan

• TestSelectColumnsExempsURLColumnsFromWidthCap — href retains actual width, description capped at 40
• TestSelectColumnsExempsURLColumnsForSuffixFields — todolists_url retains actual width (drift guard)
• Existing TestStyledRenderTablePreservesURLs updated to use a URL that fits 80-char terminal now that budget is accurate
• go vet and full test suite pass

---

Summary by cubic

Fixes table overflow by exempting URL columns from the 40‑char width cap so the column budget matches actual rendering. Keeps long URLs intact and prevents line-wrap garbling in terminal tables.

• Bug Fixes
  • Track a per-column URL flag during width measurement and skip the 40‑char cap for URL columns.
  • Applies to href, app_href, and any *_url field detected via URL parsing.
  • Added tests for href and *_url; shortened a test URL to fit an 80‑char terminal now that widths are accurate.
  • Corrected test names: “Exempts” instead of “Exemps”.

^{Written for commit 76e9247. Summary will update on new commits.}

[Copilot]

Pull request overview

Fixes a mismatch where selectColumns() capped column widths at 40 characters for column-dropping math, but formatCell() never truncated URLs, causing URL columns to overflow the terminal.

Changes:

• Added containsURL flag to the column struct, set during the existing width-measurement loop
• Skipped the 40-char width cap for columns containing URLs so budget math matches actual rendered width
• Added two new tests and updated an existing test to validate the URL exemption behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
internal/output/render.go	Added containsURL field and URL-detection logic; exempts URL columns from width cap
internal/output/output_test.go	Updated existing URL test, added two new tests for URL column width exemption

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/output/output_test.go">

<violation number="1" location="internal/output/output_test.go:2475">
P3: Typo in test name: `Exemps` → `Exempts`. This misspelling appears in both new test functions and will show up in test output / grep results.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[Copilot]

Pull request overview

Fixes a table rendering bug where URL columns overflowed the terminal because selectColumns() capped widths at 40 chars but formatCell() never truncated URLs, causing a mismatch in column budget calculations.

Changes:

• Added containsURL flag to the column struct and detect URL content during width measurement
• Skip the 40-char width cap for columns containing URLs so column-dropping math matches actual rendering
• Added two new tests and updated an existing test URL to fit within 80-char terminal width

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
internal/output/render.go	Added containsURL field and logic to exempt URL columns from width cap
internal/output/output_test.go	Added tests for URL column exemption; shortened test URL to fit terminal

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76e9247c31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".