Skip to content

Add multi-platform torch example#2449

Closed
keith wants to merge 4 commits into
bazel-contrib:mainfrom
keith:ks/add-multi-platform-torch-example
Closed

Add multi-platform torch example#2449
keith wants to merge 4 commits into
bazel-contrib:mainfrom
keith:ks/add-multi-platform-torch-example

Conversation

@keith

@keith keith commented Nov 27, 2024

Copy link
Copy Markdown
Member

This has been a useful starting point for me locally to repro pypi
downloader issues we see in our project.

@keith

keith commented Nov 27, 2024

Copy link
Copy Markdown
Member Author

should fail because of #2446

@keith

keith commented Nov 27, 2024

Copy link
Copy Markdown
Member Author

ideally after that one is fixed we could make it fail for this issue as well: #2450

currently that takes doing a query though

@keith
keith force-pushed the ks/add-multi-platform-torch-example branch from 1ac2e4e to caf3c73 Compare December 2, 2024 21:33
@keith
keith force-pushed the ks/add-multi-platform-torch-example branch from caf3c73 to 5c57c19 Compare December 9, 2024 20:34
@aignas

aignas commented Dec 12, 2024

Copy link
Copy Markdown
Collaborator

I am hesitant to add yet another example because we have many examples and not enough CI slots (or at least at some point I've heard that) and most of the cases present in the example already have unit tests, so I am not sure if this is adding anything on top of what is present in bzlmod example.

That said, the pytorch usecase has come up enough times, that I think we should probably update the bzlmod example to use pytorch as part of deps. The only annoying thing being that pytorch wheels are huge and the testing will take longer to just test requirements wiring bits, which is already covered by unit tests as I said previously.

Given that #2488 fixes the original issue, I would be willing to repurpose this work as a section in our docs on using PyPI deps. What do you think?

This has been a useful starting point for me locally to repro pypi
downloader issues we see in our project.
@keith
keith force-pushed the ks/add-multi-platform-torch-example branch from 83d5d23 to 4218c59 Compare February 21, 2025 21:26
@keith

keith commented Mar 3, 2025

Copy link
Copy Markdown
Member Author

FYI this does not seem to fix #2634, because in that example torch is coming from the same index URL either way

@keith keith closed this Mar 17, 2026
@keith
keith deleted the ks/add-multi-platform-torch-example branch March 17, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants